<html>
<head><meta charset="utf-8"><title>Snapshots ignored? · t-compiler/rust-analyzer · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/index.html">t-compiler/rust-analyzer</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Snapshots.20ignored.3F.html">Snapshots ignored?</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="202192127"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Snapshots%20ignored%3F/near/202192127" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Paul Faria <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Snapshots.20ignored.3F.html#202192127">(Jun 27 2020 at 15:45)</a>:</h4>
<p><span class="user-mention" data-user-id="133169">@matklad</span>  I noticed that a change to a highlighting snapshots somehow caused the entire file to be removed, but there was no missing file indicator. I noticed that <code>*.html</code> was recently added to <code>.gitignore</code>. Was it intended to ignore the snapshots, or are they being accidentally ignored?</p>



<a name="202192393"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Snapshots%20ignored%3F/near/202192393" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Snapshots.20ignored.3F.html#202192393">(Jun 27 2020 at 15:52)</a>:</h4>
<p>nope, that's a mistake, we should remove .html from gitignore</p>



<a name="202192546"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Snapshots%20ignored%3F/near/202192546" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Paul Faria <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Snapshots.20ignored.3F.html#202192546">(Jun 27 2020 at 15:56)</a>:</h4>
<p>want me to do it with the missing unsafe validation PR? Or separately?</p>



<a name="202192765"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Snapshots%20ignored%3F/near/202192765" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Snapshots.20ignored.3F.html#202192765">(Jun 27 2020 at 16:01)</a>:</h4>
<p>I've already r+ed the PR, so you'll need a new oen</p>



<a name="202192813"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Snapshots%20ignored%3F/near/202192813" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Paul Faria <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Snapshots.20ignored.3F.html#202192813">(Jun 27 2020 at 16:02)</a>:</h4>
<p>Ok, no worries. Will do</p>



<a name="202192815"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Snapshots%20ignored%3F/near/202192815" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Snapshots.20ignored.3F.html#202192815">(Jun 27 2020 at 16:02)</a>:</h4>
<p>wait, just push a new comment, i'll d+</p>



<a name="202192821"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Snapshots%20ignored%3F/near/202192821" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Paul Faria <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Snapshots.20ignored.3F.html#202192821">(Jun 27 2020 at 16:02)</a>:</h4>
<p>ok</p>



<a name="202192832"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Snapshots%20ignored%3F/near/202192832" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Paul Faria <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Snapshots.20ignored.3F.html#202192832">(Jun 27 2020 at 16:02)</a>:</h4>
<p>done</p>



<a name="202192854"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Snapshots%20ignored%3F/near/202192854" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Paul Faria <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Snapshots.20ignored.3F.html#202192854">(Jun 27 2020 at 16:03)</a>:</h4>
<p>ok, just r+'ed bors</p>



<a name="202194348"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Snapshots%20ignored%3F/near/202194348" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Snapshots.20ignored.3F.html#202194348">(Jun 27 2020 at 16:38)</a>:</h4>
<p>We can close <a href="https://github.com/rust-analyzer/rust-analyzer/issues/190">rust-analyzer#190</a>, right?</p>



<a name="202194568"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Snapshots%20ignored%3F/near/202194568" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jonas Schievink  [he/him] <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Snapshots.20ignored.3F.html#202194568">(Jun 27 2020 at 16:42)</a>:</h4>
<p>it's still missing <a href="https://github.com/rust-analyzer/rust-analyzer/pull/4743">https://github.com/rust-analyzer/rust-analyzer/pull/4743</a></p>



<a name="202194576"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Snapshots%20ignored%3F/near/202194576" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Snapshots.20ignored.3F.html#202194576">(Jun 27 2020 at 16:43)</a>:</h4>
<p>Ah, right</p>



<a name="202195160"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Snapshots%20ignored%3F/near/202195160" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Paul Faria <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Snapshots.20ignored.3F.html#202195160">(Jun 27 2020 at 16:57)</a>:</h4>
<p>Working on it :)</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>